]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
elf: Drop the FIXME comment in set_symbol_value
authorH.J. Lu <hjl.tools@gmail.com>
Fri, 24 Oct 2025 21:10:49 +0000 (05:10 +0800)
committerH.J. Lu <hjl.tools@gmail.com>
Fri, 24 Oct 2025 21:10:49 +0000 (05:10 +0800)
Since

commit aeaaa9af6359c8e394ce9cf24911fec4f4d23703
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Sep 23 08:52:26 2025 +0800

    elf: Return error on unsorted symbol table if not allowed

returns false when get_link_hash_entry returns NULL, we can drop the FIXME
comment now.

PR ld/33450
* elflink.c (set_symbol_value): Drop the FIXME comment.

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
bfd/elflink.c

index fd0e549eb1063f887b4c64aed5e0cfba9b3ca579..9862559b0fc0f5a345be12d4efc4db065a199c29 100644 (file)
@@ -9123,10 +9123,7 @@ set_symbol_value (bfd *bfd_with_globals,
      to "defined" and give it a value.  */
   h = get_link_hash_entry (elf_sym_hashes (bfd_with_globals), symidx, extsymoff);
   if (h == NULL)
-    {
-      /* FIXMEL What should we do ?  */
-      return false;
-    }
+    return false;
   h->root.type = bfd_link_hash_defined;
   h->root.u.def.value = val;
   h->root.u.def.section = bfd_abs_section_ptr;