]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-43498: Fix dictionary iteration error in _ExecutorManagerThread (GH-24868)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 29 Nov 2021 12:24:08 +0000 (04:24 -0800)
committerGitHub <noreply@github.com>
Mon, 29 Nov 2021 12:24:08 +0000 (04:24 -0800)
(cherry picked from commit 7431448b817d3bf87f71661cf8f3d537807ab2e2)

Co-authored-by: Jakub KulĂ­k <Kulikjak@gmail.com>
Lib/concurrent/futures/process.py
Misc/NEWS.d/next/Library/2021-04-20-14-14-16.bpo-43498.L_Hq-8.rst [new file with mode: 0644]

index 764719859f7cea583fcc2abbac270d25a28a7cb3..6ee2ce626e4567fe684c376706aff3b4997ed3bb 100644 (file)
@@ -373,7 +373,7 @@ class _ExecutorManagerThread(threading.Thread):
         assert not self.thread_wakeup._closed
         wakeup_reader = self.thread_wakeup._reader
         readers = [result_reader, wakeup_reader]
-        worker_sentinels = [p.sentinel for p in self.processes.values()]
+        worker_sentinels = [p.sentinel for p in list(self.processes.values())]
         ready = mp.connection.wait(readers + worker_sentinels)
 
         cause = None
diff --git a/Misc/NEWS.d/next/Library/2021-04-20-14-14-16.bpo-43498.L_Hq-8.rst b/Misc/NEWS.d/next/Library/2021-04-20-14-14-16.bpo-43498.L_Hq-8.rst
new file mode 100644 (file)
index 0000000..4713d14
--- /dev/null
@@ -0,0 +1,2 @@
+Avoid a possible *"RuntimeError: dictionary changed size during iteration"*
+when adjusting the process count of :class:`ProcessPoolExecutor`.