]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:utils: Do not pass invalid file descriptor to close() (CID 1550131)
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Sun, 17 Dec 2023 20:31:11 +0000 (09:31 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 21 Dec 2023 20:21:34 +0000 (20:21 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/utils/smbcacls.c

index c9ae501d1720f6563502976c2251e7609443d7e0..ff11ba4d7d7c8fa4ad66376ceb68f3eb8cd31f80 100644 (file)
@@ -2028,7 +2028,7 @@ static int cacl_dump_dacl(struct cli_state *cli,
                dump_ctx->stats->success, dump_ctx->stats->failure);
        result = EXIT_OK;
 out:
-       if (dump_ctx && dump_ctx->save_fd) {
+       if (dump_ctx && dump_ctx->save_fd > 0) {
                close(dump_ctx->save_fd);
        }
        TALLOC_FREE(ctx);