Add Rdata::getWireLength() method

diff --git a/src/lib/dns/rdata.cc b/src/lib/dns/rdata.cc
index f42c349f2d574d076437aaf69bb8ce79d4136493..09f289b7dd1169698055f5f4f4e06c62207b79aa 100644 (file)
--- a/src/lib/dns/rdata.cc
+++ b/src/lib/dns/rdata.cc
@@ -46,6 +46,15 @@ namespace isc {
 namespace dns {
 namespace rdata {
 
+uint16_t
+Rdata::getWireLength() const {
+    OutputBuffer obuffer(0);
+
+    toWire(obuffer);
+
+    return (obuffer.getLength());
+}
+
 // XXX: we need to specify std:: for string to help doxygen match the
 // function signature with that given in the header file.
 RdataPtr

diff --git a/src/lib/dns/rdata.h b/src/lib/dns/rdata.h
index 3fe0c74dd23bd8ca8c61373eb8f7695ab91910f9..352554e1affd51eba524c7cb127ae8ee68eb7bf2 100644 (file)
--- a/src/lib/dns/rdata.h
+++ b/src/lib/dns/rdata.h
@@ -221,6 +221,21 @@ public:
     /// \return > 0 if \c this would be sorted after \c other.
     virtual int compare(const Rdata& other) const = 0;
     //@}
+
+    /// \brief Get the wire format length of an Rdata.
+    ///
+    /// IMPLEMENTATION NOTE: Currently this base class implementation is
+    /// non-optimal as it renders the wire data to a buffer and returns
+    /// the buffer's length. What would perform better is to add
+    /// implementations of \c getWireLength() method to every RDATA
+    /// type. This is why this method is virtual. Once all Rdata types
+    /// have \c getWireLength() implementations, this base class
+    /// implementation must be removed and the method should become a
+    /// pure interface.
+    ///
+    /// \return The length of the wire format representation of the
+    /// RDATA.
+    virtual uint16_t getWireLength() const;
 };
 
 namespace generic {

diff --git a/src/lib/dns/tests/rdata_unittest.cc b/src/lib/dns/tests/rdata_unittest.cc
index 3839fbd24f07a6db45e3f9d12c037158abddd963..3772e9b4b0c3c90540993fad2a22448295003703 100644 (file)
--- a/src/lib/dns/tests/rdata_unittest.cc
+++ b/src/lib/dns/tests/rdata_unittest.cc
@@ -211,6 +211,14 @@ TEST_F(RdataTest, createRdataWithLexer) {
                    "file does not end with newline");
 }
 
+TEST_F(RdataTest, getWireLength) {
+    const in::AAAA aaaa_rdata("2001:db8::1");
+    EXPECT_EQ(16, aaaa_rdata.getWireLength());
+
+    const generic::TXT txt_rdata("Hello World");
+    EXPECT_EQ(12, txt_rdata.getWireLength());
+}
+
 }
 }
 }