lib: Avoid ZERO_STRUCT in pidfile_pid()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/lib/util/pidfile.c b/lib/util/pidfile.c
index b90ff12a8c76bf992c235f65f5dc9ad471529e58..bcd25fb4ba39e2ab9b70408afa63437e1701d22c 100644 (file)
--- a/lib/util/pidfile.c
+++ b/lib/util/pidfile.c
@@ -134,7 +134,7 @@ pid_t pidfile_pid(const char *piddir, const char *name)
        size_t len = strlen(piddir) + strlen(name) + 6;
        char pidFile[len];
        int fd;
-       char pidstr[20];
+       char pidstr[20] = { 0, };
        pid_t ret = -1;
 
        snprintf(pidFile, sizeof(pidFile), "%s/%s.pid", piddir, name);
@@ -145,8 +145,6 @@ pid_t pidfile_pid(const char *piddir, const char *name)
                return 0;
        }
 
-       ZERO_STRUCT(pidstr);
-
        if (read(fd, pidstr, sizeof(pidstr)-1) <= 0) {
                goto noproc;
        }