]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: dts: qcom: x1e80100-microsoft-romulus: Add missing pinctrl for eDP HPD
authorStephan Gerhold <stephan.gerhold@linaro.org>
Fri, 22 Aug 2025 09:29:00 +0000 (11:29 +0200)
committerBjorn Andersson <andersson@kernel.org>
Mon, 1 Sep 2025 18:03:33 +0000 (13:03 -0500)
At the moment, we indirectly rely on the boot firmware to set up the
pinctrl for the eDP HPD line coming from the internal display. If the boot
firmware does not configure the display (e.g. because a different display
is selected for output in the UEFI settings), then the display fails to
come up and there are several errors in the kernel log:

 [drm:dpu_encoder_phys_vid_wait_for_commit_done:544] [dpu error]vblank timeout: 80020041
 [drm:dpu_kms_wait_for_commit_done:524] [dpu error]wait for commit done returned -110
 [drm:dpu_encoder_frame_done_timeout:2715] [dpu error]enc40 frame done timeout
 ...

Fix this by adding the missing pinctrl for gpio119 (func1/edp0_hot and
bias-disable according to the ACPI DSDT), which is defined as
&edp0_hpd_default template in x1e80100.dtsi.

Fixes: 09d77be56093 ("arm64: dts: qcom: Add support for X1-based Surface Laptop 7 devices")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250822-x1e80100-add-edp-hpd-v2-9-6310176239a6@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi

index eeef0cb2606a350594f03d91762a73e4dce021a9..0ad4276e9c5f87910477c3389463a109e8d63ae6 100644 (file)
 &mdss_dp3 {
        /delete-property/ #sound-dai-cells;
 
+       pinctrl-0 = <&edp0_hpd_default>;
+       pinctrl-names = "default";
+
        status = "okay";
 
        aux-bus {