]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-45574: fix warning about `print_escape` being unused (GH-29172)
authorNikita Sobolev <mail@sobolevn.me>
Fri, 22 Oct 2021 21:57:24 +0000 (00:57 +0300)
committerGitHub <noreply@github.com>
Fri, 22 Oct 2021 21:57:24 +0000 (14:57 -0700)
It used to be like this:
<img width="1232" alt="Снимок экрана 2021-10-22 в 23 07 40" src="https://user-images.githubusercontent.com/4660275/138516608-fef6ec01-a96a-40f4-81ef-52265b0f536b.png">

Quick `grep` tells that it is just used in one place under `Py_DEBUG`: https://github.com/python/cpython/blame/f6e8b80d20159596cf641305bad3a833bedd2f4f/Parser/tokenizer.c#L1047-L1051
<img width="752" alt="Снимок экрана 2021-10-22 в 23 08 09" src="https://user-images.githubusercontent.com/4660275/138516684-ea503136-1e92-48a5-95bb-419e190d5866.png">

I am not sure, but it also looks like a private thing, it should not affect other users.

Automerge-Triggered-By: GH:pablogsal
Misc/NEWS.d/next/Library/2021-10-22-23-06-33.bpo-45574.svqA84.rst [new file with mode: 0644]
Parser/tokenizer.c

diff --git a/Misc/NEWS.d/next/Library/2021-10-22-23-06-33.bpo-45574.svqA84.rst b/Misc/NEWS.d/next/Library/2021-10-22-23-06-33.bpo-45574.svqA84.rst
new file mode 100644 (file)
index 0000000..b404d24
--- /dev/null
@@ -0,0 +1 @@
+Fix warning about ``print_escape`` being unused.
index 789a10b28fd1b557098caa56959fb98964c8e217..705da00463d1a7b402348aca21022e2237e3b1d9 100644 (file)
@@ -995,6 +995,7 @@ tok_underflow_file(struct tok_state *tok) {
     return tok->done == E_OK;
 }
 
+#if defined(Py_DEBUG)
 static void
 print_escape(FILE *f, const char *s, Py_ssize_t size)
 {
@@ -1021,6 +1022,7 @@ print_escape(FILE *f, const char *s, Py_ssize_t size)
     }
     putc('"', f);
 }
+#endif
 
 /* Get next char, updating state; error code goes into tok->done */