]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
cmake: fix missed version number for multi-pkg-config detections
authorViktor Szakats <commit@vsz.me>
Wed, 28 May 2025 16:21:17 +0000 (18:21 +0200)
committerViktor Szakats <commit@vsz.me>
Thu, 29 May 2025 04:59:02 +0000 (06:59 +0200)
It broke cmake builds with OpenSSL 3.5.0 and ngtcp2 1.12.0 or newer,
when detected via `pkg-config`.

For brotli, mbedtls, LDAP, ngtcp2 builds, it caused their version
numbers missing from the configure log when detected via `pkg-config`.

Regression from 01e45f81bddb2fef27fe35b7dd32032062a183f6 #16980
Regression from 3b501976a9adcf20218ffb96d9041806432227e4 #16479

Bug: https://github.com/curl/curl/pull/16980#issuecomment-2916811388
Reported-by: x-xiang on github
Closes #17476

CMake/FindBrotli.cmake
CMake/FindLDAP.cmake
CMake/FindMbedTLS.cmake
CMake/FindNGTCP2.cmake

index 5b280dd3fe2de06eaedbbe7960b504b56d844567..690b5a9c27ce80e65ccb29da94168dbeafa44859 100644 (file)
@@ -51,6 +51,7 @@ endif()
 
 if(BROTLI_FOUND)
   set(Brotli_FOUND TRUE)
+  set(BROTLI_VERSION "${BROTLI_libbrotlicommon_VERSION}")
   string(REPLACE ";" " " BROTLI_CFLAGS "${BROTLI_CFLAGS}")
   message(STATUS "Found Brotli (via pkg-config): ${BROTLI_INCLUDE_DIRS} (found version \"${BROTLI_VERSION}\")")
 else()
index bebad673cbec0c8d810734b371b4ef52ff4e94f8..fdc6d7be943d3e391056c6de3a220a13636133f5 100644 (file)
@@ -50,6 +50,7 @@ if(CURL_USE_PKGCONFIG AND
 endif()
 
 if(LDAP_FOUND)
+  set(LDAP_VERSION "${LDAP_ldap_VERSION}")
   string(REPLACE ";" " " LDAP_CFLAGS "${LDAP_CFLAGS}")
   message(STATUS "Found LDAP (via pkg-config): ${LDAP_INCLUDE_DIRS} (found version \"${LDAP_VERSION}\")")
 else()
index d5af4d6e77d4efe8634d68225f5d710cbf73113b..fcd6afb3ab6b7a51fbb19467e2da529a264cd710 100644 (file)
@@ -59,6 +59,7 @@ endif()
 
 if(MBEDTLS_FOUND)
   set(MbedTLS_FOUND TRUE)
+  set(MBEDTLS_VERSION "${MBEDTLS_mbedtls_VERSION}")
   string(REPLACE ";" " " MBEDTLS_CFLAGS "${MBEDTLS_CFLAGS}")
   message(STATUS "Found MbedTLS (via pkg-config): ${MBEDTLS_INCLUDE_DIRS} (found version \"${MBEDTLS_VERSION}\")")
 else()
index eb1185635e29b4107a51f10e54ec5f48c141b672..3cbd408c22c52d5ec3ae6c76bbca786b5b079201 100644 (file)
@@ -77,6 +77,7 @@ if(CURL_USE_PKGCONFIG AND
 endif()
 
 if(NGTCP2_FOUND)
+  set(NGTCP2_VERSION "${NGTCP2_libngtcp2_VERSION}")
   string(REPLACE ";" " " NGTCP2_CFLAGS "${NGTCP2_CFLAGS}")
   message(STATUS "Found NGTCP2 (via pkg-config): ${NGTCP2_INCLUDE_DIRS} (found version \"${NGTCP2_VERSION}\")")
 else()