]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
resolved: propagate correct error variable
authorLennart Poettering <lennart@poettering.net>
Mon, 22 Mar 2021 17:27:36 +0000 (18:27 +0100)
committerLennart Poettering <lennart@poettering.net>
Mon, 22 Mar 2021 17:27:36 +0000 (18:27 +0100)
src/resolve/resolved-dns-query.c

index e4386c402ac1b064be77cda5b6c8c99c48057acd..c5805111d21ff7bfa71096a00c6dd295562ce921 100644 (file)
@@ -982,12 +982,12 @@ static int dns_query_cname_redirect(DnsQuery *q, const DnsResourceRecord *cname)
         r = dns_question_cname_redirect(q->question_idna, cname, &nq_idna);
         if (r < 0)
                 return r;
-        else if (r > 0)
+        if (r > 0)
                 log_debug("Following CNAME/DNAME %s → %s.", dns_question_first_name(q->question_idna), dns_question_first_name(nq_idna));
 
         k = dns_question_is_equal(q->question_idna, q->question_utf8);
         if (k < 0)
-                return r;
+                return k;
         if (k > 0) {
                 /* Same question? Shortcut new question generation */
                 nq_utf8 = dns_question_ref(nq_idna);
@@ -996,7 +996,7 @@ static int dns_query_cname_redirect(DnsQuery *q, const DnsResourceRecord *cname)
                 k = dns_question_cname_redirect(q->question_utf8, cname, &nq_utf8);
                 if (k < 0)
                         return k;
-                else if (k > 0)
+                if (k > 0)
                         log_debug("Following UTF8 CNAME/DNAME %s → %s.", dns_question_first_name(q->question_utf8), dns_question_first_name(nq_utf8));
         }