]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: ngbe: remove netdev->ethtool->wol_enabled setting
authorJiawen Wu <jiawenwu@trustnetic.com>
Tue, 7 Apr 2026 02:56:08 +0000 (10:56 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sun, 12 Apr 2026 15:42:27 +0000 (08:42 -0700)
netdev->ethtool->wol_enabled is set in ethtool core code, so remove the
redundant setting in ngbe_set_wol().

Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Reviewed-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Joe Damato <joe@dama.to>
Link: https://patch.msgid.link/20260407025616.33652-2-jiawenwu@trustnetic.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/wangxun/ngbe/ngbe_ethtool.c

index fc04040957bfa66cd227a29181018fb11c786a68..40779fee0fdfeb6f5d69b54580e10f0f16213ded 100644 (file)
@@ -37,9 +37,8 @@ static int ngbe_set_wol(struct net_device *netdev,
        wx->wol = 0;
        if (wol->wolopts & WAKE_MAGIC)
                wx->wol = WX_PSR_WKUP_CTL_MAG;
-       netdev->ethtool->wol_enabled = !!(wx->wol);
        wr32(wx, WX_PSR_WKUP_CTL, wx->wol);
-       device_set_wakeup_enable(&pdev->dev, netdev->ethtool->wol_enabled);
+       device_set_wakeup_enable(&pdev->dev, !!(wx->wol));
 
        return 0;
 }