]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
multi: fix outdated comment
authorJay Satiro <raysatiro@yahoo.com>
Sun, 9 Feb 2020 08:15:13 +0000 (03:15 -0500)
committerJay Satiro <raysatiro@yahoo.com>
Wed, 12 Feb 2020 21:55:33 +0000 (16:55 -0500)
- Do not say that conn->data is "cleared" by multi_done().

If the connection is in use then multi_done assigns another easy handle
still using the connection to conn->data, therefore in that case it is
not cleared.

Closes https://github.com/curl/curl/pull/4901

lib/multi.c

index 6c9d06b0b59e328f95ea11624c198e4495351b87..37a37a4f0c8d8aae4eaf0143cc7bddf4af3451f9 100644 (file)
@@ -730,8 +730,8 @@ CURLMcode curl_multi_remove_handle(struct Curl_multi *multi,
        we don't leave a half-baked one around */
     if(easy_owns_conn) {
 
-      /* multi_done() clears the conn->data field to lose the association
-         between the easy handle and the connection
+      /* multi_done() clears the association between the easy handle and the
+         connection.
 
          Note that this ignores the return code simply because there's
          nothing really useful to do with it anyway! */