]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[#1818] Addressed review comments
authorThomas Markwalder <tmark@isc.org>
Wed, 19 May 2021 20:12:22 +0000 (16:12 -0400)
committerThomas Markwalder <tmark@isc.org>
Wed, 19 May 2021 20:15:59 +0000 (16:15 -0400)
    Minor cosmetics.

src/lib/util/multi_threading_mgr.h
src/lib/util/tests/multi_threading_mgr_unittest.cc

index f6230df70f0a5c252e4b47d979274ea14a627024..2fe8e50790b676cc9a1e010bc85f3d7b7a2775d7 100644 (file)
@@ -81,7 +81,7 @@ public:
     /// @brief Removes all callbacks from the list.
     void removeAll();
 
-    /// @brief Fetches the list of callbacks pairs.
+    /// @brief Fetches the list of callback pairs.
     const std::list<CSCallbackPair>& getCallbackPairs();
 
 private:
index a829d288e9b6e8fcadaae74404a883b83b0ab8a7..64182a871eef09b62d4d7ec7e05995c8218ed610 100644 (file)
@@ -386,11 +386,6 @@ public:
             if (entries.size()) {
                 // We expect entry invocations.
                 ASSERT_EQ(invocations_.size(), entries.size());
-                for (auto val :invocations_) {
-                    std::cout << val << " ";
-                }
-                std::cout << std::endl;
-
                 ASSERT_TRUE(invocations_ == entries);
             } else {
                 // We do not expect entry invocations.
@@ -436,8 +431,8 @@ public:
     std::vector<int> invocations_;
 };
 
-/// @brief Verifies that critical section callback maintenance.
-/// Catch invalid pairs, add pairs, remover pairs.
+/// @brief Verifies critical section callback maintenance:
+/// catch invalid pairs, add pairs, remove pairs.
 TEST_F(CriticalSectionCallbackTest, addAndRemove) {
     auto& mgr = MultiThreadingMgr::instance();