smbd: Simplify smb_set_posix_lock()

Instead of reading twice from pdata, use a switch statement

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
index 71d990314e3b845a332f953993c4916ecd36078f..3e364a80801195a44becddee027072514fbfa76f 100644 (file)
--- a/source3/smbd/trans2.c
+++ b/source3/smbd/trans2.c
@@ -7308,11 +7308,14 @@ static NTSTATUS smb_set_posix_lock(connection_struct *conn,
                        return NT_STATUS_INVALID_PARAMETER;
        }
 
-       if (SVAL(pdata,POSIX_LOCK_FLAGS_OFFSET) == POSIX_LOCK_FLAG_NOWAIT) {
-               blocking_lock = False;
-       } else if (SVAL(pdata,POSIX_LOCK_FLAGS_OFFSET) == POSIX_LOCK_FLAG_WAIT) {
-               blocking_lock = True;
-       } else {
+       switch (SVAL(pdata, POSIX_LOCK_FLAGS_OFFSET)) {
+       case POSIX_LOCK_FLAG_NOWAIT:
+               blocking_lock = false;
+               break;
+       case POSIX_LOCK_FLAG_WAIT:
+               blocking_lock = true;
+               break;
+       default:
                return NT_STATUS_INVALID_PARAMETER;
        }