]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
epoll: Add synchronous wakeup support for ep_poll_callback
authorXuewen Yan <xuewen.yan@unisoc.com>
Fri, 26 Apr 2024 08:05:48 +0000 (16:05 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jan 2025 12:24:55 +0000 (13:24 +0100)
commit 900bbaae67e980945dec74d36f8afe0de7556d5a upstream.

Now, the epoll only use wake_up() interface to wake up task.
However, sometimes, there are epoll users which want to use
the synchronous wakeup flag to hint the scheduler, such as
Android binder driver.
So add a wake_up_sync() define, and use the wake_up_sync()
when the sync is true in ep_poll_callback().

Co-developed-by: Jing Xia <jing.xia@unisoc.com>
Signed-off-by: Jing Xia <jing.xia@unisoc.com>
Signed-off-by: Xuewen Yan <xuewen.yan@unisoc.com>
Link: https://lore.kernel.org/r/20240426080548.8203-1-xuewen.yan@unisoc.com
Tested-by: Brian Geffon <bgeffon@google.com>
Reviewed-by: Brian Geffon <bgeffon@google.com>
Reported-by: Benoit Lize <lizeb@google.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Cc: Brian Geffon <bgeffon@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/eventpoll.c
include/linux/wait.h

index 5ce1ea1f452b1e010e50da04730608a3e4f95ccd..8962ac6eeef479b1dbf7e0843d371d349109b242 100644 (file)
@@ -1276,7 +1276,10 @@ static int ep_poll_callback(wait_queue_entry_t *wait, unsigned mode, int sync, v
                                break;
                        }
                }
-               wake_up(&ep->wq);
+               if (sync)
+                       wake_up_sync(&ep->wq);
+               else
+                       wake_up(&ep->wq);
        }
        if (waitqueue_active(&ep->poll_wait))
                pwake++;
index 1663e47681a30e069f1cb5ca596d54b0c94a15e8..aea01f678b820bdf2c2c5c4a6a74495df12f958a 100644 (file)
@@ -214,6 +214,7 @@ void __wake_up_pollfree(struct wait_queue_head *wq_head);
 #define wake_up_all(x)                 __wake_up(x, TASK_NORMAL, 0, NULL)
 #define wake_up_locked(x)              __wake_up_locked((x), TASK_NORMAL, 1)
 #define wake_up_all_locked(x)          __wake_up_locked((x), TASK_NORMAL, 0)
+#define wake_up_sync(x)                        __wake_up_sync(x, TASK_NORMAL)
 
 #define wake_up_interruptible(x)       __wake_up(x, TASK_INTERRUPTIBLE, 1, NULL)
 #define wake_up_interruptible_nr(x, nr)        __wake_up(x, TASK_INTERRUPTIBLE, nr, NULL)