drm/amdkfd: fix ref count leak when pm_runtime_get_sync fails

[ Upstream commit 1c1ada37af6ee6fb9cfc8da6a56cc83208cd8d6f ]

The call to pm_runtime_get_sync increments the counter even in case of
failure, leading to incorrect ref count.
In case of failure, decrement the ref count before returning.

Reviewed-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
index 0e0c42e9f6a3153ccbdf44dd0a0028a4fa81f767..6520a920cad4a27ddd50e65253a68ff44acb3cce 100644 (file)
--- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
@@ -1003,8 +1003,10 @@ struct kfd_process_device *kfd_bind_process_to_device(struct kfd_dev *dev,
         */
        if (!pdd->runtime_inuse) {
                err = pm_runtime_get_sync(dev->ddev->dev);
-               if (err < 0)
+               if (err < 0) {
+                       pm_runtime_put_autosuspend(dev->ddev->dev);
                        return ERR_PTR(err);
+               }
        }
 
        err = kfd_iommu_bind_process_to_device(pdd);