]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:script: Fix shellcheck errors in test_net_registry_roundtrip.sh
authorAndreas Schneider <asn@samba.org>
Thu, 3 Mar 2022 14:25:14 +0000 (15:25 +0100)
committerPavel Filipensky <pfilipensky@samba.org>
Mon, 22 Aug 2022 14:20:36 +0000 (14:20 +0000)
source3/script/tests/test_net_registry_roundtrip.sh:51:2: error: Double
quote array expansions to avoid re-splitting elements. [SC2068]

source3/script/tests/test_net_registry_roundtrip.sh:55:16: error:
Argument mixes string and array. Use * or separate argument. [SC2145]

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
source3/script/tests/test_net_registry_roundtrip.sh

index 6aeed0cd5a1918a593e8be43121f497be364068b..e1974c229e8ba68e24dbd0c68212c95470176cc9 100755 (executable)
@@ -48,11 +48,11 @@ REGPATH="HKLM\Software\Samba"
 conf_roundtrip_step()
 {
        echo "CMD: $*" >>$LOG
-       $@ 2>>$LOG
+       "$@" 2>>$LOG
        RC=$?
        echo "RC: $RC" >>$LOG
        test "x$RC" = "x0" || {
-               echo "ERROR: $@ failed (RC=$RC)" | tee -a $LOG
+               echo "ERROR: $* failed (RC=$RC)" | tee -a $LOG
        }
        return $RC
        #    echo -n .