]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
extcon: sm5502: Drop invalid register write in sm5502_reg_data
authorStephan Gerhold <stephan@gerhold.net>
Mon, 31 May 2021 13:34:35 +0000 (15:34 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:53:46 +0000 (16:53 +0200)
[ Upstream commit d25b224f8e5507879b36a769a6d1324cf163466c ]

When sm5502_init_dev_type() iterates over sm5502_reg_data to
initialize the registers it is limited by ARRAY_SIZE(sm5502_reg_data).
There is no need to add another empty element to sm5502_reg_data.

Having the additional empty element in sm5502_reg_data will just
result in writing 0xff to register 0x00, which does not really
make sense.

Fixes: 914b881f9452 ("extcon: sm5502: Add support new SM5502 extcon device driver")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/extcon/extcon-sm5502.c

index b3d93baf4fc584190e4fe5150a5ad85b2302b738..f883992800b35ebd937d96e3587ae9541881a9e5 100644 (file)
@@ -88,7 +88,6 @@ static struct reg_data sm5502_reg_data[] = {
                        | SM5502_REG_INTM2_MHL_MASK,
                .invert = true,
        },
-       { }
 };
 
 /* List of detectable cables */