]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: smbd: Remove erroneous TALLOC_FREE(smb_fname_parent) in change_file_owner_to_pare...
authorJeremy Allison <jra@samba.org>
Wed, 9 Jun 2021 19:22:26 +0000 (12:22 -0700)
committerNoel Power <npower@samba.org>
Fri, 11 Jun 2021 10:17:46 +0000 (10:17 +0000)
Caller is still using this !

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14736

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Noel Power<npower@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Fri Jun 11 10:17:46 UTC 2021 on sn-devel-184

source3/smbd/open.c

index 785a445e5cf261753f707d4123342afba33fb40c..3e48a9f35de67b7891a76a21e6fbf4fe7cc9ad16 100644 (file)
@@ -951,7 +951,6 @@ void change_file_owner_to_parent(connection_struct *conn,
                         "directory %s. Error was %s\n",
                         smb_fname_str_dbg(smb_fname_parent),
                         strerror(errno)));
-               TALLOC_FREE(smb_fname_parent);
                return;
        }
 
@@ -961,7 +960,6 @@ void change_file_owner_to_parent(connection_struct *conn,
                        "is already owned by uid %d\n",
                        fsp_str_dbg(fsp),
                        (int)fsp->fsp_name->st.st_ex_uid ));
-               TALLOC_FREE(smb_fname_parent);
                return;
        }