]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
nfsd4: simplify process_lookup1
authorJ. Bruce Fields <bfields@redhat.com>
Thu, 21 Jan 2021 22:57:37 +0000 (17:57 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Jun 2024 12:52:56 +0000 (14:52 +0200)
[ Upstream commit 33311873adb0d55c287b164117b5b4bb7b1bdc40 ]

This STALE_CLIENTID check is redundant with the one in
lookup_clientid().

There's a difference in behavior is in case of memory allocation
failure, which I think isn't a big deal.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nfsd/nfs4state.c

index e7ec7593eaaa3bb96ddd7943964e7f45fa23fd48..3f2604737636819ef8b44a58e005af8d187ef1c3 100644 (file)
@@ -4722,8 +4722,6 @@ nfsd4_process_open1(struct nfsd4_compound_state *cstate,
        struct nfs4_openowner *oo = NULL;
        __be32 status;
 
-       if (STALE_CLIENTID(&open->op_clientid, nn))
-               return nfserr_stale_clientid;
        /*
         * In case we need it later, after we've already created the
         * file and don't want to risk a further failure: