]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
resolved: test for dns_cache_put() with empty answer
authorJames Coglan <james@neighbourhood.ie>
Tue, 21 May 2024 13:39:26 +0000 (14:39 +0100)
committerJames Coglan <james@neighbourhood.ie>
Tue, 23 Jul 2024 13:08:31 +0000 (14:08 +0100)
src/resolve/test-dns-cache.c

index c9f084d3def30ef889c3f7b1859122d3f73e7a62..d708afef7b6333a2a86720472f59ee95750f05e3 100644 (file)
@@ -104,6 +104,20 @@ TEST(dns_a_success_is_cached) {
         ASSERT_FALSE(dns_cache_is_empty(&cache));
 }
 
+TEST(dns_a_success_empty_answer_is_not_cached) {
+        _cleanup_(dns_cache_unrefp) DnsCache cache = new_cache();
+        _cleanup_(put_args_unrefp) PutArgs put_args = mk_put_args();
+
+        put_args.key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com");
+        ASSERT_NOT_NULL(put_args.key);
+        put_args.rcode = DNS_RCODE_SUCCESS;
+        put_args.answer = dns_answer_new(0);
+        ASSERT_NOT_NULL(put_args.answer);
+
+        ASSERT_OK(cache_put(&cache, &put_args));
+        ASSERT_TRUE(dns_cache_is_empty(&cache));
+}
+
 TEST(dns_a_nxdomain_is_cached) {
         _cleanup_(dns_cache_unrefp) DnsCache cache = new_cache();
         _cleanup_(put_args_unrefp) PutArgs put_args = mk_put_args();