]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3/param: clang: Fix 'Value stored to 'bRetval' is never read'
authorNoel Power <noel.power@suse.com>
Thu, 11 Jul 2019 11:36:46 +0000 (11:36 +0000)
committerGary Lockyer <gary@samba.org>
Tue, 16 Jul 2019 22:52:24 +0000 (22:52 +0000)
Fixes:

source3/param/loadparm.c:2770:2: warning: Value stored to 'bRetval' is never read <--[clang]
        bRetval = false;
        ^         ~~~~~
source3/param/loadparm.c:3868:2: warning: Value stored to 'bRetval' is never read <--[clang]
        bRetval = false;
        ^         ~~~~~
2 warnings generated.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
source3/param/loadparm.c

index a8d5fdc5954d37d59b7a7023f7f74517c1f6ef85..9e97d719f4ee53f138794270dd232ae18f310418 100644 (file)
@@ -2766,7 +2766,6 @@ bool lp_do_section(const char *pszSectionName, void *userdata)
        bool bRetval;
        bool isglobal = ((strwicmp(pszSectionName, GLOBAL_NAME) == 0) ||
                         (strwicmp(pszSectionName, GLOBAL_NAME2) == 0));
-       bRetval = false;
 
        /* if we were in a global section then do the local inits */
        if (bInGlobalSection && !isglobal)
@@ -3864,8 +3863,6 @@ static bool lp_load_ex(const char *pszFname,
        TALLOC_CTX *frame = talloc_stackframe();
        struct loadparm_context *lp_ctx;
 
-       bRetval = false;
-
        DEBUG(3, ("lp_load_ex: refreshing parameters\n"));
 
        bInGlobalSection = true;