]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915: replace use of system_wq with system_percpu_wq in the documentation
authorMarco Crivellari <marco.crivellari@suse.com>
Tue, 4 Nov 2025 10:00:31 +0000 (11:00 +0100)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 5 Mar 2026 18:58:22 +0000 (13:58 -0500)
Currently if a user enqueue a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

system_wq should be the per-cpu workqueue, yet in this name nothing makes
that clear, so replace system_wq with system_percpu_wq.

This patch continues the effort to refactor worqueue APIs, which has
begun with the change introducing new workqueues:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")

The old wq (system_wq) will be kept for a few release cycles.

This change only update the documentation of drm/i915.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Link: https://patch.msgid.link/20251104100032.61525-3-marco.crivellari@suse.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/i915_driver.c
drivers/gpu/drm/i915/i915_drv.h

index 18f912043f90d418b5de40358090956a187ff091..c2365853df1b2e5aeba64ab798db2c1c83fb4800 100644 (file)
@@ -151,7 +151,7 @@ static int i915_workqueues_init(struct drm_i915_private *dev_priv)
        /*
         * The unordered i915 workqueue should be used for all work
         * scheduling that do not require running in order, which used
-        * to be scheduled on the system_wq before moving to a driver
+        * to be scheduled on the system_percpu_wq before moving to a driver
         * instance due deprecation of flush_scheduled_work().
         */
        dev_priv->unordered_wq = alloc_workqueue("i915-unordered", 0, 0);
index dd380382c00e014fd638f5cb16f4c37d6a32f0a3..dafee3dcd1c521b895aac3d0c2895012d6c13284 100644 (file)
@@ -249,7 +249,7 @@ struct drm_i915_private {
         *
         * This workqueue should be used for all unordered work
         * scheduling within i915, which used to be scheduled on the
-        * system_wq before moving to a driver instance due
+        * system_percpu_wq before moving to a driver instance due
         * deprecation of flush_scheduled_work().
         */
        struct workqueue_struct *unordered_wq;