drm/xe/pxp: Remove incorrect handling of impossible state during suspend

The default case of the PXP suspend switch is incorrectly exiting
without releasing the lock. However, this case is impossible to hit
because we're switching on an enum and all the valid enum values have
their own cases. Therefore, we can just get rid of the default case
and rely on the compiler to warn us if a new enum value is added and
we forget to add it to the switch.

Fixes: 51462211f4a9 ("drm/xe/pxp: add PXP PM support")
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Alan Previn Teres Alexis <alan.previn.teres.alexis@intel.com>
Cc: Julia Filipchuk <julia.filipchuk@intel.com>
Reviewed-by: Julia Filipchuk <julia.filipchuk@intel.com>
Link: https://patch.msgid.link/20260324153718.3155504-8-daniele.ceraolospurio@intel.com
(cherry picked from commit f1b5a77fc9b6a90cd9a5e3db9d4c73ae1edfcfac)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

diff --git a/drivers/gpu/drm/xe/xe_pxp.c b/drivers/gpu/drm/xe/xe_pxp.c
index 782281dbe9e0a67564d62642a120935b1b2fd861..fa82d606953e5da5a1cb752cfa054673eedfb45d 100644 (file)
--- a/drivers/gpu/drm/xe/xe_pxp.c
+++ b/drivers/gpu/drm/xe/xe_pxp.c
@@ -871,11 +871,6 @@ wait_for_activation:
                pxp->key_instance++;
                needs_queue_inval = true;
                break;
-       default:
-               drm_err(&pxp->xe->drm, "unexpected state during PXP suspend: %u",
-                       pxp->status);
-               ret = -EIO;
-               goto out;
        }
 
        /*
@@ -900,7 +895,6 @@ wait_for_activation:
 
        pxp->last_suspend_key_instance = pxp->key_instance;
 
-out:
        return ret;
 }