]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
serial: sc16is7xx: remove useless enable of enhanced features
authorHugo Villeneuve <hvilleneuve@dimonoff.com>
Mon, 6 Oct 2025 14:20:02 +0000 (10:20 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Oct 2025 13:09:02 +0000 (14:09 +0100)
commit 1c05bf6c0262f946571a37678250193e46b1ff0f upstream.

Commit 43c51bb573aa ("sc16is7xx: make sure device is in suspend once
probed") permanently enabled access to the enhanced features in
sc16is7xx_probe(), and it is never disabled after that.

Therefore, remove re-enable of enhanced features in
sc16is7xx_set_baud(). This eliminates a potential useless read + write
cycle each time the baud rate is reconfigured.

Fixes: 43c51bb573aa ("sc16is7xx: make sure device is in suspend once probed")
Cc: stable <stable@kernel.org>
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://patch.msgid.link/20251006142002.177475-1-hugo@hugovil.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sc16is7xx.c

index 835bd453c0e882e0b0c0f700e50a5cc33f132355..8ed8ee58e31809c4536c8b2559c714c42e60423e 100644 (file)
@@ -585,13 +585,6 @@ static int sc16is7xx_set_baud(struct uart_port *port, int baud)
                div /= prescaler;
        }
 
-       /* Enable enhanced features */
-       sc16is7xx_efr_lock(port);
-       sc16is7xx_port_update(port, SC16IS7XX_EFR_REG,
-                             SC16IS7XX_EFR_ENABLE_BIT,
-                             SC16IS7XX_EFR_ENABLE_BIT);
-       sc16is7xx_efr_unlock(port);
-
        /* If bit MCR_CLKSEL is set, the divide by 4 prescaler is activated. */
        sc16is7xx_port_update(port, SC16IS7XX_MCR_REG,
                              SC16IS7XX_MCR_CLKSEL_BIT,