]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
thermal: gov_bang_bang: Call __thermal_cdev_update() directly
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 13 Aug 2024 14:25:19 +0000 (16:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Aug 2024 15:35:36 +0000 (17:35 +0200)
commit b9b6ee6fe258ce4d89592593efcd3d798c418859 upstream.

Instead of clearing the "updated" flag for each cooling device
affected by the trip point crossing in bang_bang_control() and
walking all thermal instances to run thermal_cdev_update() for all
of the affected cooling devices, call __thermal_cdev_update()
directly for each of them.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Peter Kästle <peter@piie.net>
Reviewed-by: Zhang Rui <rui.zhang@intel.com>
Cc: 6.10+ <stable@vger.kernel.org> # 6.10+
Link: https://patch.msgid.link/13583081.uLZWGnKmhe@rjwysocki.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/thermal/gov_bang_bang.c

index acb52c9ee10f1a62fea7d47dd3d9002e189d55b0..2a6a651e9d921d1afc54a4064a1cba8f5db1d00f 100644 (file)
@@ -79,12 +79,9 @@ static void bang_bang_control(struct thermal_zone_device *tz,
                dev_dbg(&instance->cdev->device, "target=%ld\n", instance->target);
 
                mutex_lock(&instance->cdev->lock);
-               instance->cdev->updated = false; /* cdev needs update */
+               __thermal_cdev_update(instance->cdev);
                mutex_unlock(&instance->cdev->lock);
        }
-
-       list_for_each_entry(instance, &tz->thermal_instances, tz_node)
-               thermal_cdev_update(instance->cdev);
 }
 
 static struct thermal_governor thermal_gov_bang_bang = {