]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: smbd: SMB1 reply_ntrename() - the UCF_COND_ALLOW_WCARD_LCOMP makes no sense.
authorJeremy Allison <jra@samba.org>
Tue, 29 Sep 2020 03:07:36 +0000 (20:07 -0700)
committerRalph Boehme <slow@samba.org>
Wed, 30 Sep 2020 20:46:39 +0000 (20:46 +0000)
There's either a wildcard in the last component or not. Always use
UCF_ALWAYS_ALLOW_WCARD_LCOMP for calls that can take a wildcard.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/smbd/nttrans.c

index 8b3dcd87b5aa4e92556508348a5a2cd2ce1278f2..72c91e6bc9f1a0620a4c786b050aab369d4bb783 100644 (file)
@@ -1765,8 +1765,8 @@ void reply_ntrename(struct smb_request *req)
         * destination's last component.
         */
        if (rename_type == RENAME_FLAG_RENAME) {
-               ucf_flags_src |= UCF_COND_ALLOW_WCARD_LCOMP;
-               ucf_flags_dst |= UCF_COND_ALLOW_WCARD_LCOMP;
+               ucf_flags_src |= UCF_ALWAYS_ALLOW_WCARD_LCOMP;
+               ucf_flags_dst |= UCF_ALWAYS_ALLOW_WCARD_LCOMP;
        }
 
        /* rename_internals() calls unix_convert(), so don't call it here. */