]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
core: no need to eat up error
authorLennart Poettering <lennart@poettering.net>
Mon, 23 Dec 2019 15:35:44 +0000 (16:35 +0100)
committerLennart Poettering <lennart@poettering.net>
Mon, 6 Jan 2020 14:21:40 +0000 (15:21 +0100)
This is a method call reply. We might as well propagate the error. The
worst that happens is that sd-bus logs about it.

src/core/unit.c

index be92d975002de88a9c767fe9a42db56eb60abfa4..5cf16c6a79589b65a8cc3fadcba6334eac960edc 100644 (file)
@@ -3227,10 +3227,8 @@ static int get_name_owner_handler(sd_bus_message *message, void *userdata, sd_bu
         }
 
         r = sd_bus_message_read(message, "s", &new_owner);
-        if (r < 0) {
-                bus_log_parse_error(r);
-                return 0;
-        }
+        if (r < 0)
+                return bus_log_parse_error(r);
 
         if (UNIT_VTABLE(u)->bus_name_owner_change)
                 UNIT_VTABLE(u)->bus_name_owner_change(u, NULL, new_owner);