]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Issue #19595: Re-enable a long-disabled test in test_winsound
authorZachary Ware <zachary.ware@gmail.com>
Thu, 28 Nov 2013 05:56:04 +0000 (23:56 -0600)
committerZachary Ware <zachary.ware@gmail.com>
Thu, 28 Nov 2013 05:56:04 +0000 (23:56 -0600)
Lib/test/test_winsound.py
Misc/NEWS

index 61d864a64857f7ab90d7a5fd3ff16db584988340..d8a617e64fbd637eca3022b614e39ae5140ad793 100644 (file)
@@ -158,18 +158,14 @@ class PlaySoundTest(unittest.TestCase):
             )
 
     def test_alias_fallback(self):
-        # This test can't be expected to work on all systems.  The MS
-        # PlaySound() docs say:
-        #
-        #     If it cannot find the specified sound, PlaySound uses the
-        #     default system event sound entry instead.  If the function
-        #     can find neither the system default entry nor the default
-        #     sound, it makes no sound and returns FALSE.
-        #
-        # It's known to return FALSE on some real systems.
-
-        # winsound.PlaySound('!"$%&/(#+*', winsound.SND_ALIAS)
-        return
+        if _have_soundcard():
+            winsound.PlaySound('!"$%&/(#+*', winsound.SND_ALIAS)
+        else:
+            self.assertRaises(
+                RuntimeError,
+                winsound.PlaySound,
+                '!"$%&/(#+*', winsound.SND_ALIAS
+            )
 
     def test_alias_nofallback(self):
         if _have_soundcard():
index 4ed79503987d5c16a9f55820df1468af921f39a1..3c82e1ab218efbccfef7bac8dfea2e123080f853 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -31,6 +31,8 @@ Library
 Tests
 -----
 
+- Issue #19595: Re-enabled a long-disabled test in test_winsound.
+
 - Issue #19588: Fixed tests in test_random that were silently skipped most
   of the time.  Patch by Julian Gindi.