]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
selftests: arm64: Fix -Waddress warning in tpidr2 test
authorBala-Vignesh-Reddy <reddybalavignesh9979@gmail.com>
Thu, 7 Aug 2025 11:42:29 +0000 (17:12 +0530)
committerWill Deacon <will@kernel.org>
Mon, 8 Sep 2025 14:24:19 +0000 (15:24 +0100)
Thanks to -Waddress, the compiler warns that the ksft_test_result()
invocations in the arm64 tpidr2 selftest are always true. Oops.

Fix the test by, err, actually running the test functions.

Fixes: 6d80cb73131d ("kselftest/arm64: Convert tpidr2 test to use kselftest.h")
Signed-off-by: Bala-Vignesh-Reddy <reddybalavignesh9979@gmail.com>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Reviewed-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Will Deacon <will@kernel.org>
tools/testing/selftests/arm64/abi/tpidr2.c

index f58a9f89b952c42c5393b93a2db4fefe3f335e5a..4c89ab0f1010185794154dbe3aa89223639d38f4 100644 (file)
@@ -227,10 +227,10 @@ int main(int argc, char **argv)
        ret = open("/proc/sys/abi/sme_default_vector_length", O_RDONLY, 0);
        if (ret >= 0) {
                ksft_test_result(default_value(), "default_value\n");
-               ksft_test_result(write_read, "write_read\n");
-               ksft_test_result(write_sleep_read, "write_sleep_read\n");
-               ksft_test_result(write_fork_read, "write_fork_read\n");
-               ksft_test_result(write_clone_read, "write_clone_read\n");
+               ksft_test_result(write_read(), "write_read\n");
+               ksft_test_result(write_sleep_read(), "write_sleep_read\n");
+               ksft_test_result(write_fork_read(), "write_fork_read\n");
+               ksft_test_result(write_clone_read(), "write_clone_read\n");
 
        } else {
                ksft_print_msg("SME support not present\n");