]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-53502: Fix plistlib.dump() for naive datetime with aware_datetime option (GH-113645)
authorSerhiy Storchaka <storchaka@gmail.com>
Tue, 2 Jan 2024 19:45:36 +0000 (21:45 +0200)
committerGitHub <noreply@github.com>
Tue, 2 Jan 2024 19:45:36 +0000 (21:45 +0200)
Lib/plistlib.py
Lib/test/test_plistlib.py

index 6eb70cedd7aec6d35691dad477b0d648b908e448..0fc1b5cbfa8c497e95ffddc029c46cbc34fca889 100644 (file)
@@ -155,7 +155,7 @@ def _date_from_string(s, aware_datetime):
 
 
 def _date_to_string(d, aware_datetime):
-    if aware_datetime and d.tzinfo is not None:
+    if aware_datetime:
         d = d.astimezone(datetime.UTC)
     return '%04d-%02d-%02dT%02d:%02d:%02dZ' % (
         d.year, d.month, d.day,
@@ -791,7 +791,7 @@ class _BinaryPlistWriter (object):
             self._fp.write(struct.pack('>Bd', 0x23, value))
 
         elif isinstance(value, datetime.datetime):
-            if self._aware_datetime and value.tzinfo is not None:
+            if self._aware_datetime:
                 dt = value.astimezone(datetime.UTC)
                 offset = dt - datetime.datetime(2001, 1, 1, tzinfo=datetime.UTC)
                 f = offset.total_seconds()
index 010393a417b9467abcd47a850053c8e96d70b266..1d2e14a30c4e1318361778259bac0c490d3fd13f 100644 (file)
@@ -885,7 +885,8 @@ class TestPlistlib(unittest.TestCase):
         for fmt in ALL_FORMATS:
             s = plistlib.dumps(dt, fmt=fmt, aware_datetime=True)
             parsed = plistlib.loads(s, aware_datetime=False)
-            self.assertEqual(parsed, dt)
+            expected = dt.astimezone(datetime.UTC).replace(tzinfo=None)
+            self.assertEqual(parsed, expected)
 
 
 class TestBinaryPlistlib(unittest.TestCase):