- also add this to Oracle, and defensively to firebird and sybase

diff --git a/doc/build/changelog/changelog_10.rst b/doc/build/changelog/changelog_10.rst
index 281092ae12b9dfcd23e61f11921af000f4de3bc5..056ef66f74d921ec997e6dcbcbcc333825ca777e 100644 (file)
--- a/doc/build/changelog/changelog_10.rst
+++ b/doc/build/changelog/changelog_10.rst
@@ -19,16 +19,17 @@
     :version: 1.0.0b4
 
     .. change::
-        :tags: bug, mssql
+        :tags: bug, mssql, oracle, firebird, sybase
         :tickets: 3338
 
-        Turned off the "simple order by" flag on the MSSQL dialect; this
-        is the flag that per :ticket:`2992` causes an order by or group by
+        Turned off the "simple order by" flag on the MSSQL, Oracle dialects;
+        this is the flag that per :ticket:`2992` causes an order by or group by
         an expression that's also in the columns clause to be copied by
         label, even if referenced as the expression object.   The behavior
         for MSSQL is now the old behavior that copies the whole expression
         in by default, as MSSQL can be picky on these particularly in
-        GROUP BY expressions.
+        GROUP BY expressions.  The flag is also turned off defensively
+        for the Firebird and Sybase dialects.
 
     .. change::
         :tags: feature, schema

diff --git a/lib/sqlalchemy/dialects/firebird/base.py b/lib/sqlalchemy/dialects/firebird/base.py
index 61d3646b10723638ec3ce823790c5a4fede8fe4f..9d8630d3c1bcbb9853871ecdcd6de60bdaf21ddd 100644 (file)
--- a/lib/sqlalchemy/dialects/firebird/base.py
+++ b/lib/sqlalchemy/dialects/firebird/base.py
@@ -394,6 +394,8 @@ class FBDialect(default.DefaultDialect):
     requires_name_normalize = True
     supports_empty_insert = False
 
+    supports_simple_order_by_label = False
+
     statement_compiler = FBCompiler
     ddl_compiler = FBDDLCompiler
     preparer = FBIdentifierPreparer

diff --git a/lib/sqlalchemy/dialects/oracle/base.py b/lib/sqlalchemy/dialects/oracle/base.py
index f20c2f2965a2eac169d54d16dae0dbfa13ce4ab4..c605bd510c3c5ca9492585de449296ce62f831b7 100644 (file)
--- a/lib/sqlalchemy/dialects/oracle/base.py
+++ b/lib/sqlalchemy/dialects/oracle/base.py
@@ -919,6 +919,8 @@ class OracleDialect(default.DefaultDialect):
     supports_sane_rowcount = True
     supports_sane_multi_rowcount = False
 
+    supports_simple_order_by_label = False
+
     supports_sequences = True
     sequences_optional = False
     postfetch_lastrowid = False

diff --git a/lib/sqlalchemy/dialects/sybase/base.py b/lib/sqlalchemy/dialects/sybase/base.py
index 34d896347bac35c51e7c1e803244b9fa3b2b2839..57213382ea453bb9b7b50d818ceecd8a2b437be3 100644 (file)
--- a/lib/sqlalchemy/dialects/sybase/base.py
+++ b/lib/sqlalchemy/dialects/sybase/base.py
@@ -435,6 +435,7 @@ class SybaseDialect(default.DefaultDialect):
     supports_native_boolean = False
     supports_unicode_binds = False
     postfetch_lastrowid = True
+    supports_simple_order_by_label = False
 
     colspecs = {}
     ischema_names = ischema_names