]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ocfs2: remove redundant l_next_free_rec check in __ocfs2_find_path()
authorJoseph Qi <joseph.qi@linux.alibaba.com>
Fri, 3 Apr 2026 09:08:03 +0000 (17:08 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 15 Apr 2026 09:15:03 +0000 (02:15 -0700)
The l_next_free_rec > l_count check after ocfs2_read_extent_block() in
__ocfs2_find_path() is now redundant, as ocfs2_validate_extent_block()
already performs this validation at block read time.

Remove the duplicate check to avoid maintaining the same validation in two
places.

Link: https://lkml.kernel.org/r/20260403090803.3860971-5-joseph.qi@linux.alibaba.com
Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Reviewed-by: Heming Zhao <heming.zhao@suse.com>
Cc: Changwei Ge <gechangwei@live.cn>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Jun Piao <piaojun@huawei.com>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Mark Fasheh <mark@fasheh.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/ocfs2/alloc.c

index 8639806bcbb87229b2f240010666a84970a1bbe9..08e1379280801a5ac6b304a030cbc204d84ce1e1 100644 (file)
@@ -1878,18 +1878,6 @@ static int __ocfs2_find_path(struct ocfs2_caching_info *ci,
                eb = (struct ocfs2_extent_block *) bh->b_data;
                el = &eb->h_list;
 
-               if (le16_to_cpu(el->l_next_free_rec) >
-                   le16_to_cpu(el->l_count)) {
-                       ocfs2_error(ocfs2_metadata_cache_get_super(ci),
-                                   "Owner %llu has bad count in extent list at block %llu (next free=%u, count=%u)\n",
-                                   (unsigned long long)ocfs2_metadata_cache_owner(ci),
-                                   (unsigned long long)bh->b_blocknr,
-                                   le16_to_cpu(el->l_next_free_rec),
-                                   le16_to_cpu(el->l_count));
-                       ret = -EROFS;
-                       goto out;
-               }
-
                if (func)
                        func(data, bh);
        }