]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:winbind: Change num_sids from int to uint32_t in wb_lookupuseraliases_send()
authorPavel Filipenský <pfilipen@redhat.com>
Mon, 11 Jul 2022 20:39:06 +0000 (22:39 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Fri, 15 Jul 2022 14:25:38 +0000 (14:25 +0000)
Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/winbindd/wb_lookupuseraliases.c
source3/winbindd/winbindd_getsidaliases.c
source3/winbindd/winbindd_proto.h

index 49d257e883e8de9aab3a4c2c5ac6ac005c73270a..4517e066df93f11590186f2ae7450cb7919acd1d 100644 (file)
@@ -33,12 +33,12 @@ static void wb_lookupuseraliases_done(struct tevent_req *subreq);
 struct tevent_req *wb_lookupuseraliases_send(TALLOC_CTX *mem_ctx,
                                             struct tevent_context *ev,
                                             struct winbindd_domain *domain,
-                                            int num_sids,
+                                            uint32_t num_sids,
                                             const struct dom_sid *sids)
 {
        struct tevent_req *req, *subreq;
        struct wb_lookupuseraliases_state *state;
-       int i;
+       uint32_t i;
 
        req = tevent_req_create(mem_ctx, &state,
                                struct wb_lookupuseraliases_state);
@@ -47,12 +47,12 @@ struct tevent_req *wb_lookupuseraliases_send(TALLOC_CTX *mem_ctx,
        }
 
        D_INFO("WB command lookupuseraliases start.\n"
-              "Query domain %s for max %d SID(s).\n",
+              "Query domain %s for max %u SID(s).\n",
               domain->name, num_sids);
 
        for (i = 0; i < num_sids; i++) {
                struct dom_sid_buf buf;
-               D_INFO("%d: SID %s\n", i, dom_sid_str_buf(&sids[i], &buf));
+               D_INFO("%u: SID %s\n", i, dom_sid_str_buf(&sids[i], &buf));
        }
        state->sids.num_sids = num_sids;
        state->sids.sids = discard_const_p(struct dom_sid, sids);
@@ -97,10 +97,10 @@ NTSTATUS wb_lookupuseraliases_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
                return status;
        }
        *num_aliases = state->rids.num_rids;
-       D_INFO("WB command lookupuseraliases end.\nGot %d alias(es):\n",
+       D_INFO("WB command lookupuseraliases end.\nGot %u alias(es):\n",
               *num_aliases);
        for (i = 0; i < *num_aliases; i++) {
-               D_INFO("%d: RID %d\n", i, state->rids.rids[i]);
+               D_INFO("%u: RID %u\n", i, state->rids.rids[i]);
        }
 
        *aliases = talloc_move(mem_ctx, &state->rids.rids);
index de323a192514274a8c0b700d75f352cf320562a4..d3326276744eefd06980501b2298f7a78178ca71 100644 (file)
@@ -37,7 +37,7 @@ struct tevent_req *winbindd_getsidaliases_send(TALLOC_CTX *mem_ctx,
        struct tevent_req *req, *subreq;
        struct winbindd_getsidaliases_state *state;
        struct winbindd_domain *domain;
-       uint32_t num_sids;
+       uint32_t num_sids, i;
        struct dom_sid *sids;
 
        req = tevent_req_create(mem_ctx, &state,
index 6824cdbbe532012e5c519694456f59de1e4059fe..b2e33098cf91c5d28fc06ab048dd40e2450a3811 100644 (file)
@@ -649,7 +649,7 @@ NTSTATUS winbindd_getpwuid_recv(struct tevent_req *req,
 struct tevent_req *wb_lookupuseraliases_send(TALLOC_CTX *mem_ctx,
                                             struct tevent_context *ev,
                                             struct winbindd_domain *domain,
-                                            int num_sids,
+                                            uint32_t num_sids,
                                             const struct dom_sid *sids);
 NTSTATUS wb_lookupuseraliases_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
                                   uint32_t *num_aliases, uint32_t **aliases);