]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:winbind: Improve logging in wb_lookupusergroups.c
authorPavel Filipenský <pfilipen@redhat.com>
Sun, 19 Jun 2022 18:48:31 +0000 (20:48 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Fri, 15 Jul 2022 14:25:38 +0000 (14:25 +0000)
Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/winbindd/wb_lookupusergroups.c

index bc14c33a88d1317193decc84420ddc4669db6684..de3d184fa99b5215d8aa98f0b9f64e33ae11c8ac 100644 (file)
@@ -38,12 +38,15 @@ struct tevent_req *wb_lookupusergroups_send(TALLOC_CTX *mem_ctx,
        struct wb_lookupusergroups_state *state;
        struct winbindd_domain *domain;
        NTSTATUS status;
+       struct dom_sid_buf buf;
 
        req = tevent_req_create(mem_ctx, &state,
                                struct wb_lookupusergroups_state);
        if (req == NULL) {
                return NULL;
        }
+       D_INFO("WB command lookupusergroups start.\nLooking up SID %s.\n",
+              dom_sid_str_buf(sid, &buf));
        sid_copy(&state->sid, sid);
 
        status = lookup_usergroups_cached(state,
@@ -57,7 +60,6 @@ struct tevent_req *wb_lookupusergroups_send(TALLOC_CTX *mem_ctx,
 
        domain = find_domain_from_sid_noinit(&state->sid);
        if (domain == NULL) {
-               struct dom_sid_buf buf;
                DBG_WARNING("could not find domain entry for sid %s\n",
                            dom_sid_str_buf(&state->sid, &buf));
                tevent_req_nterror(req, NT_STATUS_NO_SUCH_DOMAIN);
@@ -84,6 +86,7 @@ static void wb_lookupusergroups_done(struct tevent_req *subreq)
        status = dcerpc_wbint_LookupUserGroups_recv(subreq, state, &result);
        TALLOC_FREE(subreq);
        if (any_nt_status_not_ok(status, result, &status)) {
+               D_WARNING("Failed with %s.\n", nt_errstr(status));
                tevent_req_nterror(req, status);
                return;
        }
@@ -96,11 +99,19 @@ NTSTATUS wb_lookupusergroups_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
        struct wb_lookupusergroups_state *state = tevent_req_data(
                req, struct wb_lookupusergroups_state);
        NTSTATUS status;
+       int i;
 
        if (tevent_req_is_nterror(req, &status)) {
                return status;
        }
        *num_sids = state->sids.num_sids;
        *sids = talloc_move(mem_ctx, &state->sids.sids);
+
+       D_INFO("WB command lookupusergroups end.\nReceived %d SID(s).\n",
+              *num_sids);
+       for (i = 0; i < *num_sids; i++) {
+               struct dom_sid_buf buf;
+               D_INFO("%d: %s\n", i, dom_sid_str_buf(&*sids[i], &buf));
+       }
        return NT_STATUS_OK;
 }