tests: Clean up 'test_checks'

* Make use of 'create_' helper
* Remove unneeded 'XXX.objects.delete()' calls (all objects are deleted
  on teardown of each test)
* Include every import on its own line

Signed-off-by: Stephen Finucane <stephen.finucane@intel.com>
Reviewed-by: Andy Doan <andy.doan@linaro.org>

diff --git a/patchwork/tests/test_checks.py b/patchwork/tests/test_checks.py
index 2ed5070e9770f25082a61bd357822724e0e50fbf..0508704ae510c54d58bb4dcf17a7e13bc2ddba55 100644 (file)
--- a/patchwork/tests/test_checks.py
+++ b/patchwork/tests/test_checks.py
@@ -22,22 +22,16 @@ from datetime import timedelta
 
 from django.test import TransactionTestCase
 
-from patchwork.models import Patch, Check
-from patchwork.tests.utils import defaults, create_user
+from patchwork.models import Check
+from patchwork.tests.utils import create_patches
+from patchwork.tests.utils import create_user
 
 
 class PatchChecksTest(TransactionTestCase):
     fixtures = ['default_tags', 'default_states']
 
     def setUp(self):
-        project = defaults.project
-        defaults.project.save()
-        defaults.patch_author_person.save()
-        self.patch = Patch(project=project,
-                           msgid='x', name=defaults.patch_name,
-                           submitter=defaults.patch_author_person,
-                           diff='')
-        self.patch.save()
+        self.patch = create_patches()[0]
         self.user = create_user()
 
     def create_check(self, **kwargs):
@@ -89,9 +83,6 @@ class PatchChecksTest(TransactionTestCase):
             if state not in state_counts:
                 self.assertEqual(counts[state], 0)
 
-    def tearDown(self):
-        self.patch.delete()
-
     def test_checks__no_checks(self):
         self.assertChecksEqual(self.patch, [])