core: limit the number of units that can be requested over ListUnitsByNames

diff --git a/src/core/dbus-manager.c b/src/core/dbus-manager.c
index 1bc73e7b434c91a3d1af8e19296216c419c7e1a1..6579708df0117b8bfa640039cf0cf07d0368e8cc 100644 (file)
--- a/src/core/dbus-manager.c
+++ b/src/core/dbus-manager.c
@@ -971,6 +971,10 @@ static int method_list_units_by_names(sd_bus_message *message, void *userdata, s
         if (r < 0)
                 return r;
 
+        if (strv_length(units) > MAX(hashmap_size(m->units), (unsigned) MANAGER_MAX_NAMES / 2))
+                return sd_bus_error_set(reterr_error, SD_BUS_ERROR_LIMITS_EXCEEDED,
+                                        "Too many unit names requested.");
+
         r = sd_bus_message_new_method_return(message, &reply);
         if (r < 0)
                 return r;