]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
dns_record_match: drop pretense of HINFO support
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Tue, 13 Apr 2021 00:06:16 +0000 (12:06 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 11 Jun 2021 08:38:34 +0000 (08:38 +0000)
We don't support it really, and if we did there is no sense in which
it could be updated, which is the context in which this function is
used.

(modern HINFO returns the constant string "RFC8482". See RFC 8482).

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/dns_server/dnsserver_common.c

index b0b430342ad97c1036debbeaa059e4a8e3a99260..855323035fbadd2216060202b778e0d725948cbf 100644 (file)
@@ -1329,10 +1329,6 @@ bool dns_records_match(struct dnsp_DnssrvRpcRecord *rec1,
                return rec1->data.mx.wPriority == rec2->data.mx.wPriority &&
                        dns_name_equal(rec1->data.mx.nameTarget, rec2->data.mx.nameTarget);
 
-       case DNS_TYPE_HINFO:
-               return strcmp(rec1->data.hinfo.cpu, rec2->data.hinfo.cpu) == 0 &&
-                       strcmp(rec1->data.hinfo.os, rec2->data.hinfo.os) == 0;
-
        case DNS_TYPE_SOA:
                return dns_name_equal(rec1->data.soa.mname, rec2->data.soa.mname) &&
                        dns_name_equal(rec1->data.soa.rname, rec2->data.soa.rname) &&