]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: TAS2781: Fix tasdev_load_calibrated_data()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 19 Jul 2024 23:53:48 +0000 (18:53 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Aug 2024 07:01:06 +0000 (09:01 +0200)
[ Upstream commit 92c78222168e9035a9bfb8841c2e56ce23e51f73 ]

This function has a reversed if statement so it's either a no-op or it
leads to a NULL dereference.

Fixes: b195acf5266d ("ASoC: tas2781: Fix wrong loading calibrated data sequence")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/18a29b68-cc85-4139-b7c7-2514e8409a42@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/tas2781-fmwlib.c

index 838d29fead961e10ff9283723e8e8be898dd1aa3..08082806d5892801077471bafbea9137fad617e3 100644 (file)
@@ -2163,7 +2163,7 @@ static void tasdev_load_calibrated_data(struct tasdevice_priv *priv, int i)
                return;
 
        cal = cal_fmw->calibrations;
-       if (cal)
+       if (!cal)
                return;
 
        load_calib_data(priv, &cal->dev_data);