test: Disable unit test causing issue with nightly package

Signed-off-by: David Goulet <dgoulet@torproject.org>

diff --git a/changes/ticket40918 b/changes/ticket40918
new file mode 100644 (file)
index 0000000..7d5e549
--- /dev/null
+++ b/changes/ticket40918
@@ -0,0 +1,3 @@
+  o Minor bugfix (relay, sandbox):
+    - Disable a sandbox unit test that is failing on Debian Sid breaking our
+      nightly packages. Fixes bug 40918; bugfix on 0.3.5.1-alpha.

diff --git a/src/test/test_sandbox.c b/src/test/test_sandbox.c
index 3104790723e57ab2c8dcad4463c6b14b8eba47e9..edb5c0c23247afa8fe762ba1a627569416d91380 100644 (file)
--- a/src/test/test_sandbox.c
+++ b/src/test/test_sandbox.c
@@ -377,9 +377,19 @@ struct testcase_t sandbox_tests[] = {
 #else
   SANDBOX_TEST_IN_SANDBOX(open_filename),
   SANDBOX_TEST_IN_SANDBOX(openat_filename),
-  SANDBOX_TEST_IN_SANDBOX(opendir_dirname),
 #endif /* defined(ENABLE_FRAGILE_HARDENING) */
 
+  /* Ok why... Quick answer is #40918. This has been failing on Debian SID
+   * making us unable to have nightly packages which is a problem as we have
+   * several relay operators using them and actively reporting us issues with
+   * them. This test fails due to the sandbox denying it.
+   *
+   * We are deprecating C-tor slowly and honestly, the Sandbox feature has
+   * always been a source of pain and unhappiness. Disable this as finding why,
+   * fixing it and hoping it doesn't come back will mostly be a waste of our
+   * time at this point. */
+  SANDBOX_TEST_SKIPPED(opendir_dirname),
+
   SANDBOX_TEST_IN_SANDBOX(chmod_filename),
   SANDBOX_TEST_IN_SANDBOX(chown_filename),
   SANDBOX_TEST_IN_SANDBOX(rename_filename),