]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
librpc: Fix CID 1455913 Use after free
authorVolker Lendecke <vl@samba.org>
Tue, 19 Nov 2019 13:17:38 +0000 (14:17 +0100)
committerAndreas Schneider <asn@cryptomilk.org>
Tue, 19 Nov 2019 16:13:36 +0000 (16:13 +0000)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
librpc/rpc/dcerpc_util.c

index 1fb3fa720753b463170874b1cf4e151d4e47fdc9..32df534d5d9f426dbfb8a50509b2defe89eb066b 100644 (file)
@@ -1434,10 +1434,11 @@ void dcerpc_log_packet(const char *lockdir,
                }
 
                saved = file_save(name, pkt->data, pkt->length);
-               free(name);
                if (saved) {
                        DBG_DEBUG("Logged rpc packet to %s\n", name);
+                       free(name);
                        break;
                }
+               free(name);
        }
 }