]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
sched/fair: Have SD_SERIALIZE affect newidle balancing
authorPeter Zijlstra <peterz@infradead.org>
Mon, 17 Nov 2025 16:13:09 +0000 (17:13 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Mon, 17 Nov 2025 16:13:09 +0000 (17:13 +0100)
Also serialize the possiblty much more frequent newidle balancing for
the 'expensive' domains that have SD_BALANCE set.

Initial benchmarking by K Prateek and Tim showed no negative effect.

Split out from the larger patch moving sched_balance_running around
for ease of bisect and such.

Suggested-by: Shrikanth Hegde <sshegde@linux.ibm.com>
Seconded-by: K Prateek Nayak <kprateek.nayak@amd.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/df068896-82f9-458d-8fff-5a2f654e8ffd@amd.com
Link: https://patch.msgid.link/6fed119b723c71552943bfe5798c93851b30a361.1762800251.git.tim.c.chen@linux.intel.com
# Conflicts:
# kernel/sched/fair.c

kernel/sched/fair.c

index 59b17f09166b8fe24e743eef959775382bdc7eda..071e07f8cb27dccc83119e48576a589af4820889 100644 (file)
@@ -11732,7 +11732,7 @@ redo:
                goto out_balanced;
        }
 
-       if (!need_unlock && (sd->flags & SD_SERIALIZE) && idle != CPU_NEWLY_IDLE) {
+       if (!need_unlock && (sd->flags & SD_SERIALIZE)) {
                int zero = 0;
                if (!atomic_try_cmpxchg_acquire(&sched_balance_running, &zero, 1))
                        goto out_balanced;