systemctl: fix bad memory access when mangle_names() fails (#5485)

Fixes #5483

diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c
index 157a46865ff8e71ebcbc3aa48536df5ee93e7eae..d78e56d777e1e9abb9cd37207a33354a109df39b 100644 (file)
--- a/src/systemctl/systemctl.c
+++ b/src/systemctl/systemctl.c
@@ -5964,6 +5964,7 @@ static int mangle_names(char **original_names, char ***mangled_names) {
                 } else {
                         r = unit_name_mangle(*name, UNIT_NAME_NOGLOB, i);
                         if (r < 0) {
+                                *i = NULL;
                                 strv_free(l);
                                 return log_error_errno(r, "Failed to mangle unit name: %m");
                         }