patch 9.2.0889: VMS: spurious "INVALID DECC FEATURE VALUE" message at every startup

Problem:  On OpenVMS, Vim prints "INVALID DECC FEATURE VALUE" once per
          DECC feature at every startup whenever that feature is already
          set to the value Vim wants -- e.g. when DECC$ARGV_PARSE_STYLE,
          DECC$EFS_CASE_PRESERVE or DECC$EFS_CHARSET are defined as
          logical names. Conversely, a genuinely out-of-range value is
          silently ignored, so the diagnostic fires exactly when it
          should not and never when it should (after v9.1.1591)
Solution: Add braces so that the "else" binds to the range check rather
          than to the inner "if", matching the existing indentation and
          the evident intent (Scott Klein).

related: #17810
closes:  #20904

Supported by AI.

Signed-off-by: Scott Klein <kleinmatic@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

diff --git a/src/os_vms.c b/src/os_vms.c
index 17fa067743e73a02f132b12dc12a62c43158f153..3c822993942d5e99c0d836181074a2482cb3c561 100644 (file)
--- a/src/os_vms.c
+++ b/src/os_vms.c
@@ -1005,9 +1005,11 @@ vms_init(void)
            feat_value_max = decc$feature_get_value(feat_index, 3);
 
            if ((decc_feat_array[i].value >= feat_value_min) && (decc_feat_array[i].value <= feat_value_max))
+           {
                // Valid value.  Set it if necessary
                if (feat_value != decc_feat_array[i].value)
                    sts = decc$feature_set_value(feat_index, 1, decc_feat_array[i].value);
+           }
            else
                // Invalid DECC feature value
                printf("INVALID DECC FEATURE VALUE, %d: %d <= %s <= %d.\n",

diff --git a/src/version.c b/src/version.c
index 0fdd61f59f5222befa590b278597a6ee640de5ff..dcec47b1065f3381c1c3ad7026c7806175951582 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -758,6 +758,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    889,
 /**/
     888,
 /**/