]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
Revert "libcli/auth: let netlogon_creds_cli_store_internal check netlogon_creds_Crede...
authorStefan Metzmacher <metze@samba.org>
Tue, 29 Oct 2024 16:33:39 +0000 (17:33 +0100)
committerStefan Metzmacher <metze@samba.org>
Thu, 5 Dec 2024 16:46:37 +0000 (16:46 +0000)
This reverts commit c3fa132fbe179bd4e1451240ce572ec791356a16.

We break the compat of the netlogon_creds_cli.tdb records compared to
4.21 with the next commits.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
libcli/auth/netlogon_creds_cli.c
librpc/idl/schannel.idl

index 1750ea3703cfc0f0fd7297a0afebc8b2608e9288..256ab0090120bea37228edf9a5a26a2462d138a4 100644 (file)
@@ -756,7 +756,6 @@ static NTSTATUS netlogon_creds_cli_store_internal(
        enum ndr_err_code ndr_err;
        DATA_BLOB blob;
        TDB_DATA data;
-       struct netlogon_creds_CredentialState_legacy lc = { .sequence = 0, };
 
        if (DEBUGLEVEL >= 10) {
                NDR_PRINT_DEBUG(netlogon_creds_CredentialState, creds);
@@ -770,18 +769,6 @@ static NTSTATUS netlogon_creds_cli_store_internal(
                return status;
        }
 
-       ndr_err = ndr_pull_struct_blob_all(&blob, frame, &lc,
-               (ndr_pull_flags_fn_t)ndr_pull_netlogon_creds_CredentialState_legacy);
-       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               status = ndr_map_error2ntstatus(ndr_err);
-               TALLOC_FREE(frame);
-               return status;
-       }
-
-       if (DEBUGLEVEL >= 11) {
-               NDR_PRINT_DEBUG(netlogon_creds_CredentialState_legacy, &lc);
-       }
-
        data.dptr = blob.data;
        data.dsize = blob.length;
 
index 9fe4b7aed7c75c3fcef616d278efdc98652fa020..8905d514f557a038e7d753ea6a4f66c1be908a11 100644 (file)
@@ -85,19 +85,6 @@ interface schannel
                netlogon_creds_CredentialState_extra_info *ex;
        } netlogon_creds_CredentialState;
 
-       typedef [public,flag(NDR_PAHEX)] struct {
-               netr_NegotiateFlags negotiate_flags;
-               uint8 session_key[16];
-               uint32 sequence;
-               netr_Credential seed;
-               netr_Credential client;
-               netr_Credential server;
-               netr_SchannelType secure_channel_type;
-               [string,charset(UTF8)] uint8 computer_name[];
-               [string,charset(UTF8)] uint8 account_name[];
-               dom_sid *sid;
-       } netlogon_creds_CredentialState_legacy;
-
        /* This is used in the schannel_store.tdb */
        typedef [public] struct {
                [string,charset(UTF16)] uint16 *computer_name;