Closed TODO: AsyncCalls solved the "reentrant commConnectStart" problem;

the warning comments are no longer needed.

diff --git a/src/ICAP/ICAPModXact.cc b/src/ICAP/ICAPModXact.cc
index 96cccea8751ce60ef601dcba5780ab8bcfae9783..f6c39d07442e28dc5a38dd5bf9e6567f5c2d0ff6 100644 (file)
--- a/src/ICAP/ICAPModXact.cc
+++ b/src/ICAP/ICAPModXact.cc
@@ -80,11 +80,6 @@ void ICAPModXact::start()
         startWriting();
     else
         waitForService();
-
-    // XXX: If commConnectStart in startWriting fails, we may get here
-    //_after_ the object got destroyed. Somebody please fix commConnectStart!
-    // TODO: Does re-entrance protection in callStart() solve the above?
-    // TODO: Check that comm using AsyncCalls solves this problem.
 }
 
 void ICAPModXact::waitForService()
@@ -118,8 +113,6 @@ void ICAPModXact::startWriting()
     decideOnRetries();
 
     openConnection();
-    // put nothing here as openConnection calls commConnectStart
-    // and that may call us back without waiting for the next select loop
 }
 
 // connection with the ICAP service established