]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: lpfc: Fix incorrect dbde assignment when building target abts wqe
authorJames Smart <jsmart2021@gmail.com>
Mon, 1 Mar 2021 17:18:00 +0000 (09:18 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 May 2021 12:04:08 +0000 (14:04 +0200)
[ Upstream commit 9302154c07bff4e7f7f43c506a1ac84540303d06 ]

The wqe_dbde field indicates whether a Data BDE is present in Words 0:2 and
should therefore should be clear in the abts request wqe. By setting the
bit we can be misleading fw into error cases.

Clear the wqe_dbde field.

Link: https://lore.kernel.org/r/20210301171821.3427-2-jsmart2021@gmail.com
Co-developed-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/lpfc/lpfc_nvmet.c

index f14394ab0e037f5249d45c9527d87886cb02772e..ce2e2b58fa7e6659a1d4045b88a7c9df5bd94bfa 100644 (file)
@@ -3204,7 +3204,6 @@ lpfc_nvmet_unsol_issue_abort(struct lpfc_hba *phba,
        bf_set(wqe_rcvoxid, &wqe_abts->xmit_sequence.wqe_com, xri);
 
        /* Word 10 */
-       bf_set(wqe_dbde, &wqe_abts->xmit_sequence.wqe_com, 1);
        bf_set(wqe_iod, &wqe_abts->xmit_sequence.wqe_com, LPFC_WQE_IOD_WRITE);
        bf_set(wqe_lenloc, &wqe_abts->xmit_sequence.wqe_com,
               LPFC_WQE_LENLOC_WORD12);