s4:rpc_server/netlogon: fix error codes in dcesrv_netr_NetrLogonSendToSam

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Dec  5 17:46:49 UTC 2024 on atb-devel-224

diff --git a/selftest/knownfail.d/samba.tests.krb5.netlogon b/selftest/knownfail.d/samba.tests.krb5.netlogon
index 3da1d7368e5d70a2fccb4f1cc1a5dec601f66e9c..ce9255442db41030b11b2f2ed0e4953118435580 100644 (file)
--- a/selftest/knownfail.d/samba.tests.krb5.netlogon
+++ b/selftest/knownfail.d/samba.tests.krb5.netlogon
@@ -1,7 +1,5 @@
 # Without AES we currently get DOWNGRADE_DETECTED
 ^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_.*_auth3_00004004
 ^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_.*_auth3_603fffff
-# These need to be checked
-^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_send_to_sam
 # This is not implemented yet
 ^samba.tests.krb5.netlogon.*.NetlogonSchannel.test_ticket_samlogon

diff --git a/source4/rpc_server/netlogon/dcerpc_netlogon.c b/source4/rpc_server/netlogon/dcerpc_netlogon.c
index 0667a1205075902a123ac3ee28716b015a673b30..b3a71b3cb59280168f4d6eadf6ee846b4a041116 100644 (file)
--- a/source4/rpc_server/netlogon/dcerpc_netlogon.c
+++ b/source4/rpc_server/netlogon/dcerpc_netlogon.c
@@ -3234,7 +3234,7 @@ static NTSTATUS dcesrv_netr_NetrLogonSendToSam(struct dcesrv_call_state *dce_cal
        case SEC_CHAN_DNS_DOMAIN:
        case SEC_CHAN_DOMAIN:
        case SEC_CHAN_NULL:
-               return NT_STATUS_INVALID_PARAMETER;
+               return NT_STATUS_ACCESS_DENIED;
        default:
                DEBUG(1, ("Client asked for an invalid secure channel type: %d\n",
                          creds->secure_channel_type));
@@ -3264,8 +3264,7 @@ static NTSTATUS dcesrv_netr_NetrLogonSendToSam(struct dcesrv_call_state *dce_cal
                                       (ndr_pull_flags_fn_t)ndr_pull_netr_SendToSamBase);
 
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               /* We only partially implement SendToSam */
-               return NT_STATUS_NOT_IMPLEMENTED;
+               return NT_STATUS_INVALID_PARAMETER;
        }
 
        /* Now 'send' to SAM */
@@ -3289,7 +3288,7 @@ static NTSTATUS dcesrv_netr_NetrLogonSendToSam(struct dcesrv_call_state *dce_cal
                                           &dn);
                if (ret != LDB_SUCCESS) {
                        ldb_transaction_cancel(sam_ctx);
-                       return NT_STATUS_INVALID_PARAMETER;
+                       return NT_STATUS_OBJECT_NAME_NOT_FOUND;
                }
 
                if (creds->secure_channel_type == SEC_CHAN_RODC &&