]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
extcon: max14526: depends on I2C to prevent build warning/errors
authorRandy Dunlap <rdunlap@infradead.org>
Thu, 15 May 2025 23:48:03 +0000 (16:48 -0700)
committerChanwoo Choi <cw00.choi@samsung.com>
Mon, 8 Sep 2025 06:13:06 +0000 (15:13 +0900)
Make EXTCON_MAX14526 depend on I2C to address a kconfig warning and
subsequent build errors:

WARNING: unmet direct dependencies detected for REGMAP_I2C
  Depends on [m]: I2C [=m]
  Selected by [y]:
  - EXTCON_MAX14526 [=y] && EXTCON [=y]

ld: vmlinux.o: in function `max14526_driver_init':
extcon-max14526.c:(.init.text+0x77b0e): undefined reference to `i2c_register_driver'
ld: vmlinux.o: in function `max14526_driver_exit':
extcon-max14526.c:(.exit.text+0x467c): undefined reference to `i2c_del_driver'

Fixes: 145af3ddd1cd ("extcon: Add basic support for Maxim MAX14526 MUIC")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Link: https://lore.kernel.org/lkml/20250515234803.1385375-1-rdunlap@infradead.org/
drivers/extcon/Kconfig

index 1096afc0b5bb2c044adb6aacb6e50c19cd379052..aec46bf03302c9ef6e18c3d574c78e1365d898d8 100644 (file)
@@ -136,6 +136,7 @@ config EXTCON_MAX8997
 
 config EXTCON_MAX14526
        tristate "Maxim MAX14526 EXTCON Support"
+       depends on I2C
        select IRQ_DOMAIN
        select REGMAP_I2C
        help