]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
analyze: add forgotten return statement
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Fri, 7 Oct 2022 13:52:33 +0000 (15:52 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 11 Oct 2022 14:59:00 +0000 (16:59 +0200)
We would fail with an assert in sd_bus_message_enter_container() afterwards.

src/analyze/analyze-dot.c

index 13bea4598fce0c85cba13770fe26f0572f40e71e..bf8aa8148fc82ed3db1feade7abd37e9929fe380 100644 (file)
@@ -149,7 +149,7 @@ int verb_dot(int argc, char *argv[], void *userdata) {
 
         r = bus_call_method(bus, bus_systemd_mgr, "ListUnits", &error, &reply, NULL);
         if (r < 0)
-                log_error_errno(r, "Failed to list units: %s", bus_error_message(&error, r));
+                return log_error_errno(r, "Failed to list units: %s", bus_error_message(&error, r));
 
         r = sd_bus_message_enter_container(reply, SD_BUS_TYPE_ARRAY, "(ssssssouso)");
         if (r < 0)