]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
xfs: fix returned valued from xfs_defer_can_append
authorCarlos Maiolino <cem@kernel.org>
Wed, 4 Mar 2026 18:54:27 +0000 (19:54 +0100)
committerCarlos Maiolino <cem@kernel.org>
Fri, 6 Mar 2026 08:30:07 +0000 (09:30 +0100)
xfs_defer_can_append returns a bool, it shouldn't be returning
a NULL.

Found by code inspection.

Fixes: 4dffb2cbb483 ("xfs: allow pausing of pending deferred work items")
Cc: <stable@vger.kernel.org> # v6.8
Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Acked-by: Souptick Joarder <souptick.joarder@hpe.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/libxfs/xfs_defer.c

index 472c261163ed4665c6e038fc1e9d8a795a80470a..c6909716b041518ad91437d89e7a7adb7a0194a1 100644 (file)
@@ -809,7 +809,7 @@ xfs_defer_can_append(
 
        /* Paused items cannot absorb more work */
        if (dfp->dfp_flags & XFS_DEFER_PAUSED)
-               return NULL;
+               return false;
 
        /* Already full? */
        if (ops->max_items && dfp->dfp_count >= ops->max_items)